Add gatsby-transformer-remark to npm install in gatsby-remark-prismjs README
#2673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ismjs` README
This may be totally intuitive to some, but if you add `gatsby-remark-prismjs` as shown above without having added `gatsby-transformer-remark`, you get a build failure:
```
prichey@BE7700 ~/g/prichey-gatsby (master)> yarn deploy
yarn run v1.2.1
$ gatsby build --prefix-paths && gh-pages -d public
success delete html files from previous builds — 0.046 s
success open and validate gatsby-config.js — 0.007 s
error Unable to find plugin "gatsby-transformer-remark"
Error: Unable to find plugin "gatsby-transformer-remark"
- load-plugins.js:96 resolvePlugin
[prichey-gatsby]/[gatsby]/dist/bootstrap/load-plugins.js:96:11
- load-plugins.js:147 processPlugin
[prichey-gatsby]/[gatsby]/dist/bootstrap/load-plugins.js:147:27
- load-plugins.js:168
[prichey-gatsby]/[gatsby]/dist/bootstrap/load-plugins.js:168:28
- Array.forEach
- load-plugins.js:167 _callee$
[prichey-gatsby]/[gatsby]/dist/bootstrap/load-plugins.js:167:28
- index.js:122 _callee$
[prichey-gatsby]/[gatsby]/dist/bootstrap/index.js:122:20
error Command failed with exit code 1.
```
Small change, but it would save beginners from running into the same error I just hit.
|
Deploy preview ready! Built with commit da32669 |
|
👍 makes sense! |
|
Do you think you could make the same change to the other gatsby-remark-* READMEs? |
|
Sure, I’d be happy to!
…________________________________
From: Kyle Mathews <[email protected]>
Sent: Monday, October 30, 2017 12:01:11 PM
To: gatsbyjs/gatsby
Cc: Preston Richey; Author
Subject: Re: [gatsbyjs/gatsby] Add `gatsby-transformer-remark` to `npm install` in `gatsby-remark-prismjs` README (#2673)
Do you think you could make the same change to the other gatsby-remark-* READMEs?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#2673 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ABWk9_G1QhLLXy49mAJciJbh8L_sib5qks5sxgDXgaJpZM4QKfTv>.
|
|
Hiya @prichey! 👋 This is definitely late, but on behalf of the entire Gatsby community, I wanted to say thank you for being here. Gatsby is built by awesome people like you. Let us say “thanks” in two ways:
If you have questions, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’. Thanks again! 💪💜 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may be totally intuitive to some, but if you add
gatsby-remark-prismjsas shown above without having addedgatsby-transformer-remark, you get a build failure:Small change, but it would save beginners from running into the same error I just hit.